Skip to content

fix(twitter): extract cookie parsing into helper function#196

Merged
Panniantong merged 1 commit intomainfrom
rebase/fix-twitter-cookie-parse
Mar 23, 2026
Merged

fix(twitter): extract cookie parsing into helper function#196
Panniantong merged 1 commit intomainfrom
rebase/fix-twitter-cookie-parse

Conversation

@Panniantong
Copy link
Owner

Summary

Rebased version of PR #190 by @srxly888-creator — thank you for the contribution! 🎉

Extracts the Twitter cookie parsing logic from _cmd_configure() into a standalone _parse_twitter_cookie_input() function, improving maintainability and testability.

Changes

  • agent_reach/cli.py: Extract cookie parsing into _parse_twitter_cookie_input()
  • tests/test_cli.py: Add 2 test cases for cookie parsing (separate values + header string)

Tests

✅ All 10 CLI tests pass after rebase onto latest main (post bird migration).

Closes #191
Supersedes #190

Co-authored-by: srxly888-creator

@Panniantong Panniantong merged commit 0c6c45a into main Mar 23, 2026
8 checks passed
@Panniantong Panniantong deleted the rebase/fix-twitter-cookie-parse branch March 23, 2026 10:35
Citrus086 added a commit to Citrus086/Agent-Reach that referenced this pull request Mar 24, 2026
Merge upstream changes from Panniantong/Agent-Reach:

New Features:
- Add Xueqiu (雪球) channel for stock quotes (Panniantong#198)
- Migrate Twitter from xreach to bird CLI (Panniantong#193)
- Support OPENCLAW_HOME environment variable (Panniantong#194)
- Add skill auto-install on doctor + XHS formatter (Panniantong#199)
- Rich UI for doctor (Panniantong#170)

Bug Fixes:
- XHS Windows compatibility (Panniantong#159)
- Reddit doctor User-Agent (Panniantong#168)
- Twitter cookie parsing (Panniantong#196)

Preserved Custom Features:
- Boss直聘 channel
- skill/references/*.md structure
- Custom update command
- OPENCLAW_HOME merged with local _copy_skill_dir()

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: twitter-cookies parsing fails for some valid input formats

1 participant